Skip to content

Linkify SMTP.quit() in smtplib documentation.#9785

Merged
miss-islington merged 2 commits into
python:masterfrom
taketakeyyy:fix/typo_smtplib_quit
Nov 23, 2018
Merged

Linkify SMTP.quit() in smtplib documentation.#9785
miss-islington merged 2 commits into
python:masterfrom
taketakeyyy:fix/typo_smtplib_quit

Conversation

@taketakeyyy

@taketakeyyy taketakeyyy commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@taketakeyyy taketakeyyy requested a review from a team as a code owner October 10, 2018 04:07
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 10, 2018
@JulienPalard

JulienPalard commented Oct 10, 2018

Copy link
Copy Markdown
Member

Hi and thanks for you PR.

This was not a typo, the ~ masks the first element of the reference, so instead of displaying smtplib.quit, only quit is shown.

But there's a bigger error, quit is not from smtplib but from SMTP instances, so what about:

:meth:`SMTP.quit`

? This would create a clickable link to the quit method, instead of unclickable-text to a non-existing method.

@taketakeyyy

taketakeyyy commented Oct 10, 2018

Copy link
Copy Markdown
Contributor Author

Thank you for teaching me! I misunderstood.
The cause why it is not clickable is just what you said, I think.
should I fix it with other PR?

@matrixise

matrixise commented Oct 12, 2018

Copy link
Copy Markdown
Member

Hi @taketakeyyy just add a new commit to this PR where you fix with

:meth:`SMTP.quit`

@taketakeyyy

taketakeyyy commented Oct 13, 2018

Copy link
Copy Markdown
Contributor Author

@matrixise
thank you for your advice!

@Mariatta Mariatta changed the title fix: typo Linkify SMTP.quit() in smtplib documentation. Nov 23, 2018
@miss-islington miss-islington merged commit ba57963 into python:master Nov 23, 2018
@miss-islington

miss-islington commented Nov 23, 2018

Copy link
Copy Markdown
Contributor

Thanks @taketakeyyy for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
3e1cf1f 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 23, 2018

Copy link
Copy Markdown

GH-10681 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Nov 23, 2018

Copy link
Copy Markdown

GH-10682 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

bedevere-bot commented Nov 23, 2018

Copy link
Copy Markdown

GH-10683 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
3d7d4a9 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2018
@taketakeyyy @miss-islington
Linkify SMTP.quit() in smtplib documentation. (pythonGH-9785)
8901e05 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
70cc092 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
832da87 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
miss-islington added a commit that referenced this pull request Nov 23, 2018
@miss-islington @taketakeyyy
Linkify SMTP.quit() in smtplib documentation. (GH-9785)
0ef0398 
(cherry picked from commit ba57963)

Co-authored-by: takey <taketakeyyy@gmail.com>
pablogsal pushed a commit that referenced this pull request Apr 29, 2020
@tonybaloney
bpo-40432 Fix MSBuild project for Pegen grammars (#GH-9785)
9b64ef3 
* Update the source path of the pegen target within the Windows regen project.
Change the path to Windows path formats.

* Use the more reliable SetEnv task for Cpp Projects in MSBuild.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@taketakeyyy @JulienPalard @matrixise @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni